Fix docx writer: skip directory entries when building media overrides#11379
Merged
Fix docx writer: skip directory entries when building media overrides#11379
Conversation
d6ba70f to
c545d2b
Compare
jgm
reviewed
Jan 5, 2026
test/Tests/Writers/OOXML.hs
Outdated
Comment on lines
+92
to
+95
| setTranslations "en-US" | ||
| mblang <- toLang (Just (Text.pack "en-US") :: Maybe Text) | ||
| maybe (return ()) setTranslations mblang |
Contributor
Author
There was a problem hiding this comment.
Thank you for your feedback. You're right that the previous change introduced unnecessary complexity. I have now updated the code and removed the extra dependency.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pandoc docx writer adds an
<Override>for/word/media/in[Content_Types].xmlwhen the reference doc contains media, which violates OPC rules and causes Word to report corruption.Fix
Filter out directory entries when building media overrides so only real files produce
Overridenodes.Tests
[Content_Types].xmldoes not contain/word/media/override when using a reference doc with media.Related Issue