pptx writer: Handle reference doc without slides#11310
Merged
Conversation
Add an empty sldIdLst at the correct position if one is missing in the reference doc so that modifySldIdLst can replace it. Also apply hlint suggestion to use elem.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty
sldIdLstis now added if the reference doc is missing one so thatmodifySldIdLstcan replace it. To ensure PowerPoint doesn't say that the file will need fixing, thesldIdLsthas to be placed after thesldMasterIdLst. I also added a test to ensure that if there are notes, they will be placed between thesldMasterIdLstandsldIdLst. Otherwise PowerPoint wouldn't show the slide of a note when viewing Notes Pages.Since I'm reusing existing logic, I combined some of it into shared functions to avoid code duplication.
Fixes: #7536