If we are using a div here, we might consider adding wrapper="1", so that it can be "unwrapped" in formats that allow putting an attribute directly on a horizontal rule.

@tarleb does that make sense?

For the class name, should it be pagebreak or page-break?

Or should we go whole hog and add PageBreak to the AST?

Ah right, page-break would be better. English orthography remains a challenge for me, even after all those years :D

I had forgotten about our wrapper convention. @RayBB, the LLM will probably be able to assist with that. If not, please ping me here.

Or should we go whole hog and add PageBreak to the AST?

I'll probably have about a week of quiet time soon, in which I should be able to work on some of those bigger changes. I guess we'd want to bundle a couple of AST changes into a single release?

Right, I guess in German you are used to jamming words together!

I'm not sure about the AST change. I don't like to rely on string typing, though. So if there are a significant number of formats that would support page breaks, and we're willing to put in the work to support them in readers and writers, it might be worth considering. AST changes are disruptive, though.

It seems that you both are still considering a different approach of adding this to the AST more broadly.

I'm not sure if that means you want to merge this PR in the mean time or just wait.

In any case, I renamed pagebreak to page-break and added wrapper=1 so I think your suggestions are addressed if you do want to merge this. @tarleb

PS: If you want to squash and merge that's fine. Or I can do that locally and push it up if necessary.

Excellent, thanks! I think the plan is to merge this, we're just thinking out loud about possible alternatives and future changes.