remove empty attr check in fenced_divs#10960
Merged
Conversation
Owner
|
|
Collaborator
|
Related issue, for spans: #10802 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the check discussed in #10955. I talked with @tarleb who proposed to simply remove the check instead of adding an additional extension.
It's a mere 1-line PR. 4 tests now fail:
test/command/4164.md
2 tests in
pandoc tests.Old.markdown.writer.basic(I think that's how you specify this one? There didn't appear to be a .md directly linked)1 test in
opml.basic, and the test suite reports:By inspection, they all appear to be tests that, predictably, expect
<div>...</div>to be in the output. But I don't know if the particular<div>syntax is important here or not.