Remove potential reliance on ActiveSupport::Inflector#constantize

jgarber-cisco · jgarber-cisco · commit 740011b51ca7 · 2025-02-20T07:43:49.000-05:00
`constantize` is basically an alias for `Object.const_get`, so why are we doing gymnastics to avail ourselves of it? https://github.com/rails/rails/blob/cf6ff17e9a3c6c1139040b519a341f55f0be16cf/activesupport/lib/active_support/inflector/methods.rb#L289
diff --git a/sentry-resque/lib/sentry/resque.rb b/sentry-resque/lib/sentry/resque.rb
@@ -40,11 +40,8 @@ def record(queue, worker, payload, &block)
 
               finish_transaction(transaction, 200)
             rescue Exception => exception
-              klass = if payload["class"].respond_to?(:constantize)
-                payload["class"].constantize
-              else
-                Object.const_get(payload["class"].to_s)
-              end
+              klass = payload["class"]
+              klass = Object.const_get(klass) unless klass.is_a?(Class)
 
               raise if Sentry.configuration.resque.report_after_job_retries &&
                        defined?(::Resque::Plugins::Retry) == "constant" &&
