Conversation
Owner
Author
|
@ccoVeille can you please review this PR? There may be room for some further improvements as well. |
ccoVeille
reviewed
Jul 20, 2024
1149ef3 to
2f52e89
Compare
ccoVeille
reviewed
Jul 21, 2024
|
I'm in the mountain and I have low coverage internet. I'm sorry if I'm able to publish my review now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convcommand internals based in feedback provided by @ccoVeille in PR #5t.Helper()to internal testing functionsREADME.mdQ&A:Convert from one group of date/time units to anothershrinkPeriod()functionconvfunctionsremoveTrailingS()