Command Summary - New record functionality#1230
Merged
EyalDelarea merged 38 commits intojfrog:devfrom Aug 21, 2024
Merged
Conversation
enchance build info table
…mmand_summary_to_cli
4 tasks
4 tasks
EyalDelarea
commented
Aug 14, 2024
This was referenced Aug 18, 2024
Merged
eyalbe4
suggested changes
Aug 18, 2024
artifactory/commands/commandssummaries/buildinfosummary_test.go
Outdated
Show resolved
Hide resolved
| @@ -15,23 +15,23 @@ const ( | |||
| ) | |||
|
|
|||
Contributor
There was a problem hiding this comment.
The entire commandssummaries package is located directory under the artifactory/commands package. This is wriwrongng, because commandssummaries isn't a command.
I therefore suggest moving the entire commandssummaries directory to be under artifactory/utils.
…mmand_summary_to_cli
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the existing simple data recording function, we now have the capability to record data with a predefined 'index'. This allows us to categorize and store specific information that can be easily accessed by other components within the summary report.
The main example of this usage is storing indexed scan results, which can later be attached to specific files in the summary.
Here’s an example of how to use the new function:
Will resolve to a file system like this:
The supported indexes so far are:
Note
This change also requires that the generation of markdown will happen via a CLI command, rather than automatically. The PR in the CLI will introduce a new command called "create-summary-markdown".