Skip to content

Skip VCS stamping in Go#93

Merged
yahavi merged 2 commits intojfrog:masterfrom
yahavi:go-skip-vcs
Dec 29, 2022
Merged

Skip VCS stamping in Go#93
yahavi merged 2 commits intojfrog:masterfrom
yahavi:go-skip-vcs

Conversation

@yahavi
Copy link
Copy Markdown
Member

@yahavi yahavi commented Dec 27, 2022 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Depends on: jfrog/build-info#689

  • Allow providing the dontBuildVcs flag, which can be used to skip VCS stamping to bypass the following error:

IOException: error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping. error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping.

  • Remove code duplication in Go tree building

@yahavi yahavi self-assigned this Dec 27, 2022
@yahavi yahavi mentioned this pull request Dec 27, 2022
Merged
1 task
@asafgabai asafgabai mentioned this pull request Dec 29, 2022
Merged
1 task
@yahavi yahavi changed the title Allow skip VCS stamping in Go Skip VCS stamping in Go Dec 29, 2022
@yahavi yahavi added the bug Something isn't working label Dec 29, 2022
@yahavi yahavi merged commit 770eac9 into jfrog:master Dec 29, 2022
@yahavi yahavi deleted the go-skip-vcs branch December 29, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@attiasas attiasas Awaiting requested review from attiasas

@asafgabai asafgabai Awaiting requested review from asafgabai

1 more reviewer

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yahavi yahavi

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yahavi @eyalbe4