Store CVEs in cache#61
Merged
yahavi merged 4 commits intojfrog:masterfrom Nov 2, 2021
Merged
Conversation
1 task
eyalbe4
suggested changes
Nov 2, 2021
| add(issue); | ||
| }}, new HashSet<>()); | ||
| this.add(artifact); | ||
| Artifact artifact = new Artifact(info, Sets.newHashSet(issue), new HashSet<>()); |
Contributor
There was a problem hiding this comment.
Something I noticed about the Artifact class -
Its constructor receieve two hashsets, but inside the class, these hashets are also initialized upon defibition, whicg seem redundant. I therefore suggest changing -
public class Artifact implements Serializable {
private static final long serialVersionUID = 1L;
private GeneralInfo generalInfo = new GeneralInfo();
private Set<Issue> issues = new HashSet();
private Set<License> licenses = new HashSet();
public Artifact() {
}
public Artifact(GeneralInfo generalInfo, Set<Issue> issues, Set<License> licenses) {
this.generalInfo = generalInfo;
this.issues = issues;
this.licenses = licenses;
}
into -
public class Artifact implements Serializable {
private static final long serialVersionUID = 1L;
private GeneralInfo generalInfo;
private Set<Issue> issues;
private Set<License> licenses;
public Artifact() {
generalInfo = new GeneralInfo();
issues = new HashSet();
licenses = new HashSet();
}
public Artifact(GeneralInfo generalInfo, Set<Issue> issues, Set<License> licenses) {
this.generalInfo = generalInfo;
this.issues = issues;
this.licenses = licenses;
}
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store CVEs in cache and increase cache version from 0 to 1, to make sure the cache will be initialized.