Skip to content

Fix for maven conditional upload scenarios#836

Merged
agrasth merged 1 commit intojfrog:masterfrom
agrasth:mvnScanfix-2
Oct 29, 2025
Merged

Fix for maven conditional upload scenarios#836
agrasth merged 1 commit intojfrog:masterfrom
agrasth:mvnScanfix-2

Conversation

@agrasth
Copy link
Copy Markdown
Contributor

@agrasth agrasth commented Oct 29, 2025

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.

Fixes issue in Maven extractor 2.43.1 where artifact metadata was not collected for conditional upload scenarios (XRay scan before deploy).

Problem:

  • mvn verify fix (skipping artifacts when publish.artifacts=false) was too aggressive
  • Broke conditional upload feature which needs artifact metadata for XRay scanning

Solution:

  • Check shouldAddDeployableArtifacts()
  • Skip when metadata is NOT explicitly requested
  • Preserves mvn verify fix while supporting conditional upload

@agrasth agrasth added bug Create a report to help us improve safe to test Approve running integration tests on a pull request labels Oct 29, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 29, 2025
@agrasth agrasth merged commit 8f04ef3 into jfrog:master Oct 29, 2025
46 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Create a report to help us improve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant