Skip to content

Bugfix - Use the correct plugins endpoints#635

Merged
Or-Geva merged 1 commit intojfrog:masterfrom
kamrup:use-correct-plugins-endpoints
Apr 5, 2022
Merged

Bugfix - Use the correct plugins endpoints#635
Or-Geva merged 1 commit intojfrog:masterfrom
kamrup:use-correct-plugins-endpoints

Conversation

@kamrup
Copy link
Copy Markdown
Contributor

@kamrup kamrup commented Apr 4, 2022

This wrong endpoints seem to have been used since
67cefb2.

jfrog/jenkins-artifactory-plugin#659

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kamrup
Copy link
Copy Markdown
Contributor Author

kamrup commented Apr 4, 2022

I have read the CLA Document and I hereby sign the CLA

@kamrup
Copy link
Copy Markdown
Contributor Author

kamrup commented Apr 4, 2022

I'm not sure if the changes require new tests - they don't seem to be covered at the moment.
I tried running the Extractor tests as mentioned in the README but they fail for what seem to be unrelated reasons.

@kamrup kamrup marked this pull request as ready for review April 4, 2022 20:52
@Or-Geva Or-Geva self-requested a review April 5, 2022 06:19
@Or-Geva
Copy link
Copy Markdown
Contributor

Or-Geva commented Apr 5, 2022

@kamrup, thank you for your contribution. I apologize for the inconvenience caused by the wrong endpoints for Execute and Get UserPlugin. To be sure, I checked the other UserPlugin endpoints (getStagingStrategy & executeUserPlugin) and they are all ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants