Skip to content

Split URL encoding to query and path encodings#619

Merged
yahavi merged 5 commits intojfrog:masterfrom
yahavi:encode-url
Mar 6, 2022
Merged

Split URL encoding to query and path encodings#619
yahavi merged 5 commits intojfrog:masterfrom
yahavi:encode-url

Conversation

@yahavi
Copy link
Copy Markdown
Member

@yahavi yahavi commented Feb 17, 2022

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Resolves jfrog/jenkins-artifactory-plugin#592

URL encoding should be applied to 2 different scenarios:

  1. Encode URL path part, like build-name and build-number. This type of encoding should encode slashes to %2F.
  2. Encode all other cases - like multiple path parts or a query. This type if encoding does not encode slashes.

@yahavi yahavi merged commit 7739d42 into jfrog:master Mar 6, 2022
@yahavi yahavi deleted the encode-url branch March 6, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Special characters in the build names are not encoded in the artifactory url and failing to open from Jenkins UI

2 participants