Fix Docker module name in build-info#617
Merged
yahavi merged 1 commit intojfrog:masterfrom Feb 15, 2022
Merged
Conversation
eyalbe4
approved these changes
Feb 15, 2022
|
This pull request broke the module id name for any image that contains more than one slash. See #665 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently, there are at least 2 ways to configure the Docker registry URL:
Expected
In the generated build-info, the module ID should be
<image-name>/<image-tag>.Actual
When configuring URL to Docker repository as a Docker registry, the module ID, in this case:
docker-local/<image-name>/<image-tag>.