Skip to content

Add support for v2 compatible go projects with submodule as root#594

Merged
yahavi merged 1 commit intojfrog:masterfrom
jfrog-qa:bugfix/RTDEV-3462
Dec 28, 2021
Merged

Add support for v2 compatible go projects with submodule as root#594
yahavi merged 1 commit intojfrog:masterfrom
jfrog-qa:bugfix/RTDEV-3462

Conversation

@jfrog-qa
Copy link
Copy Markdown
Contributor

@jfrog-qa jfrog-qa commented Dec 26, 2021

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 26, 2021

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

eyalbe4
eyalbe4 suggested changes Dec 26, 2021
View reviewed changes
...nfo-extractor-go/src/main/java/org/jfrog/build/extractor/go/extractor/GoZipBallStreamer.java Outdated
@@ -238,29 +244,59 @@ private boolean isSubFolderOfAnotherModule(String moduleRootDir, String director
* @return True if the entry is a go.mod file which doesn't belong to the project we are packing
*/
private boolean isSubModule(String entryName) {
Copy link
Copy Markdown
Contributor

@eyalbe4 eyalbe4 Dec 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a unit test for this method.

yahavi
yahavi requested changes Dec 26, 2021
View reviewed changes
@yahavi
Copy link
Copy Markdown
Member

yahavi commented Dec 26, 2021

Please also rename the title of the PR to something more informative than Bugfix/rtdev 3462

@jfrog-qa jfrog-qa force-pushed the bugfix/RTDEV-3462 branch 2 times, most recently from 32006cf to f699202 Compare December 27, 2021 07:57
@jfrog-qa jfrog-qa changed the title Bugfix/rtdev 3462 Add support for v2 compatible go projects with submodule as root Dec 27, 2021
@jfrog-qa jfrog-qa force-pushed the bugfix/RTDEV-3462 branch 2 times, most recently from 8d79ea9 to a28768b Compare December 28, 2021 06:42
@yahavi yahavi merged commit 6a3684d into jfrog:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yahavi yahavi yahavi requested changes

+1 more reviewer

@eyalbe4 eyalbe4 eyalbe4 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jfrog-qa @yahavi @eyalbe4 @AsafZalcman