Add support for new Xray graph scan (Xray java client)#556
Merged
talarian1 merged 6 commits intojfrog:masterfrom Sep 30, 2021
Merged
Add support for new Xray graph scan (Xray java client)#556talarian1 merged 6 commits intojfrog:masterfrom
talarian1 merged 6 commits intojfrog:masterfrom
Conversation
Contributor
talarian1
commented
Sep 26, 2021
- All tests passed. If this feature is not already covered by the tests, I added new tests.
yahavi
requested changes
Sep 26, 2021
Member
yahavi
left a comment
There was a problem hiding this comment.
Looks good.
Please consider my comments and the following general guidelines:
- Add some tests to DependencyTreeTest.
- Make sure to reformat code.
- Make sure to suppress or handle compiler warnings.
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java
Outdated
Show resolved
Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java
Outdated
Show resolved
Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java
Outdated
Show resolved
Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java
Outdated
Show resolved
Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java
Outdated
Show resolved
Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java
Show resolved
Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/License.java
Outdated
Show resolved
Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/License.java
Outdated
Show resolved
Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/Artifact.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Yahav Itzhak <yahavi@users.noreply.github.com>
yahavi
requested changes
Sep 27, 2021
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java
Show resolved
Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java
Show resolved
Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/Artifact.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.