Allow npm projects without name and versions#546
Merged
yahavi merged 2 commits intojfrog:masterfrom Aug 15, 2021
Merged
Conversation
eyalbe4
suggested changes
Aug 15, 2021
| * @param workingDir - The package.json directory | ||
| * @return <name>:<version>, <name> or <directory-name> | ||
| */ | ||
| static String getProjectName(JsonNode npmList, Path workingDir) { |
Contributor
There was a problem hiding this comment.
static String --> private static String
Member
Author
There was a problem hiding this comment.
But this function is in use in the test
...o-extractor-npm/src/main/java/org/jfrog/build/extractor/npm/extractor/NpmDependencyTree.java
Show resolved
Hide resolved
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package.jsonfiles are allowed to be without name and version nodes. Currently, the code throws NPE in such cases.If
nameis missing, use the directory name as the project name.If only
versionis missing, use the name without the version as the project name.Otherwise, use : as the project name.