Rollback artifactTarget and add targetRepo to json output#532
Merged
gailazar300 merged 3 commits intojfrog:masterfrom Jul 13, 2021
Merged
Rollback artifactTarget and add targetRepo to json output#532gailazar300 merged 3 commits intojfrog:masterfrom
gailazar300 merged 3 commits intojfrog:masterfrom
Conversation
Contributor
gailazar300
commented
Jul 12, 2021
- All tests passed. If this feature is not already covered by the tests, I added new tests.
eyalbe4
suggested changes
Jul 13, 2021
| */ | ||
| private Boolean deploySucceeded; | ||
| /** | ||
| * Target deploy repository. |
| // Save information returned from Artifactory after deployed. | ||
| artifact.setDeploySucceeded(true); | ||
| artifact.setSha256(response.getChecksums().getSha256()); | ||
| // In case of a SNAPSHOT deploy artifact's name is being modify by artifactory. |
Contributor
There was a problem hiding this comment.
// In case of a SNAPSHOT deploy artifact's name is being modify by artifactory.
-->
// When a maven SNAPSHOT artifact is deployed, Artifactory adds a timestamp to the artifact name, after the artifact is deployed.
| deployableArtifacts.forEach(artifact -> { | ||
| try { | ||
| ArtifactoryUploadResponse response = artifactoryManager.upload(artifact, logPrefix); | ||
| // Save information returned from Artifactory after deployed. |
Contributor
There was a problem hiding this comment.
... after deployed. --> ... after the deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.