Bugfix - Error when trying to download an empty (zero bytes size) file#507
Merged
Or-Geva merged 3 commits intojfrog:masterfrom May 30, 2021
Merged
Bugfix - Error when trying to download an empty (zero bytes size) file#507Or-Geva merged 3 commits intojfrog:masterfrom
Or-Geva merged 3 commits intojfrog:masterfrom
Conversation
yahavi
requested changes
May 28, 2021
Member
yahavi
left a comment
There was a problem hiding this comment.
I think we there is no point in creating a new input stream if the response type is EMPTY.
Moreover, shouldn't we call handleEmptyEntity() in that case?
If you agree with the above, please consider changing processResponse to the following:
private void processResponse(HttpEntity entity) throws IOException {
if (entity == null || responseType == JFrogServiceResponseType.EMPTY) {
handleEmptyEntity();
return;
}
try (InputStream stream = entity.getContent()) {
setResponse(stream);
}
}
Contributor
Author
You're right.
No, private void processResponse(HttpEntity entity) throws IOException {
if (responseType == JFrogServiceResponseType.EMPTY) {
return;
}
if (entity == null ) {
handleEmptyEntity();
}
try (InputStream stream = entity.getContent()) {
setResponse(stream);
}
} |
Member
|
@Or-Geva OK, but please add Javadoc above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All JFrog services ignore response with zero content length, this isn't fit to upload service, as it stops the download flow before reaching file creation. Therefore it was removed.
Fixes jfrog/jenkins-artifactory-plugin#490