Skip to content

Restructuring Artifactory APIs#493

Merged
Or-Geva merged 6 commits intojfrog:masterfrom
Or-Geva:ArtifactoryManager
May 23, 2021
Merged

Restructuring Artifactory APIs#493
Or-Geva merged 6 commits intojfrog:masterfrom
Or-Geva:ArtifactoryManager

Conversation

@Or-Geva
Copy link
Copy Markdown
Contributor

@Or-Geva Or-Geva commented May 17, 2021 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • Removed: ArtifactoryBaseClient, ArtifactoryBuildInfoClient and ArtifactoryDependenciesClient clients.
  • Added: Artifactory Manager client which has all the old clients' APIs.
  • Moved: Steam/contents/entities use into Artifactory Manager.
  • Transferred each Rest API into a dedicated service (new class).
    Related: Artifactory manager jenkins-artifactory-plugin#477

@Or-Geva Or-Geva requested review from eyalbe4 and yahavi May 17, 2021 08:14
@Or-Geva Or-Geva mentioned this pull request May 20, 2021
Merged
2 tasks
yahavi
yahavi requested changes May 20, 2021
View reviewed changes
Or-Geva added 2 commits May 23, 2021 11:36
@Or-Geva
Merge remote-tracking branch 'origin/master' into ArtifactoryManager
05cc959
@Or-Geva
Merge remote-tracking branch 'origin/master' into ArtifactoryManager
4622e8e 
Fix CR comments
# Conflicts:
#	build-info-extractor-gradle/src/main/groovy/org/jfrog/gradle/plugin/artifactory/task/DeployTask.java
@Or-Geva Or-Geva merged commit 67cefb2 into jfrog:master May 23, 2021
@yahavi yahavi mentioned this pull request May 25, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yahavi yahavi yahavi requested changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Or-Geva @yahavi