Merged
Conversation
Contributor
asafgabai
commented
Apr 28, 2021
- All tests passed. If this feature is not already covered by the tests, I added new tests.
…ixed scopes. In addition, npm logs are not silent anymore and are printed to the logger.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
…ses a bug in some npm versions.
yahavi
requested changes
May 2, 2021
Member
yahavi
left a comment
There was a problem hiding this comment.
Awesome work @asafgabai!
Please consider my inline comments.
build-info-extractor-npm/src/main/java/org/jfrog/build/extractor/npm/NpmDriver.java
Outdated
Show resolved
Hide resolved
build-info-extractor-npm/src/main/java/org/jfrog/build/extractor/npm/NpmDriver.java
Outdated
Show resolved
Hide resolved
build-info-extractor-npm/src/main/java/org/jfrog/build/extractor/npm/NpmDriver.java
Outdated
Show resolved
Hide resolved
build-info-extractor-npm/src/main/java/org/jfrog/build/extractor/npm/NpmDriver.java
Outdated
Show resolved
Hide resolved
build-info-extractor-npm/src/main/java/org/jfrog/build/extractor/npm/NpmDriver.java
Outdated
Show resolved
Hide resolved
...tractor-npm/src/main/java/org/jfrog/build/extractor/npm/extractor/NpmBuildInfoExtractor.java
Outdated
Show resolved
Hide resolved
build-info-extractor-npm/src/main/java/org/jfrog/build/extractor/npm/NpmDriver.java
Outdated
Show resolved
Hide resolved
...tractor-npm/src/main/java/org/jfrog/build/extractor/npm/extractor/NpmBuildInfoExtractor.java
Show resolved
Hide resolved
...tractor-npm/src/main/java/org/jfrog/build/extractor/npm/extractor/NpmBuildInfoExtractor.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.