Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
eyalbe4
suggested changes
May 4, 2021
Contributor
eyalbe4
left a comment
There was a problem hiding this comment.
Following our recent experience, I suggest we keep supporting NuGet protocol v2 by default, and allow setting the protocol version to v3.
Currently Jenkins is the only user of this API, so I suggest adding a v3 option to the pipelines DSL of Jenkins, so that uses can choose to use v3.
fbfd069 to
e7d0f72
Compare
eyalbe4
suggested changes
May 18, 2021
...d-info-extractor-nuget/src/main/java/org/jfrog/build/extractor/nuget/extractor/NugetRun.java
Outdated
Show resolved
Hide resolved
...d-info-extractor-nuget/src/main/java/org/jfrog/build/extractor/nuget/extractor/NugetRun.java
Outdated
Show resolved
Hide resolved
...d-info-extractor-nuget/src/main/java/org/jfrog/build/extractor/nuget/extractor/NugetRun.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~ Change NuGet protocol from V2 to V3.
~ Improve dependencies source interpretation.