Conversation
lsf37
commented
Dec 31, 2022
lsf37
commented
Dec 31, 2022
lsf37
commented
Dec 31, 2022
lsf37
commented
Dec 31, 2022
f2e076c to
dc688b1
Compare
- move char class creation to after the entire spec has been parsed, so we definitively know the input char set - to do that, factor out char class creation from scanner and parser into own pass - to do that, make pre-defined classes and unicode property classes parts of the syntax tree as opposed to inline unfolded char sets - to do that, factor out regexp char class normalisation into own pass (separate from macro expansion), so that this normalisation can be done after pre-defined classes are converted to char sets - add error message for declaring input char set twice - make CharClasses.init() private (use constructor instead) Fixes #986
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add test case for char class directives delete existing classes #986
move char class creation to after the entire spec has been parsed, so we definitively know the input char set
to do that, factor out char class creation from scanner and parser into own pass
to do that, make pre-defined classes and unicode property classes parts of the syntax tree as opposed to inline unfolded char sets
to do that, factor out regexp char class normalisation into own pass (separate from macro expansion), so that this normalisation can be done after pre-defined classes are converted to char sets
add error message for declaring input char set twice
make CharClasses.init() private (use constructor instead)
Fixes #986