Skip to content

Make maven build reproducible#765

Merged
lsf37 merged 2 commits intojflex-de:masterfrom
hboutemy:master
Jan 7, 2023
Merged

Make maven build reproducible#765
lsf37 merged 2 commits intojflex-de:masterfrom
hboutemy:master

Conversation

@hboutemy
Copy link
Contributor

@hboutemy hboutemy commented May 16, 2020 •
edited by regisd
Loading

  • Hardcode an initial value for <project.build.outputTimestamp>
  • Update maven plugins to version 3.2+

see https://maven.apache.org/guides/mini/guide-reproducible-builds.html

@hboutemy hboutemy requested a review from lsf37 as a code owner May 16, 2020 11:14
@regisd regisd self-assigned this May 16, 2020
@regisd regisd self-requested a review May 16, 2020 19:16
@regisd regisd added the enhancement Feature requests label May 16, 2020
@regisd regisd added this to the 1.9.0 milestone May 16, 2020
regisd
regisd reviewed May 16, 2020
View reviewed changes
Copy link
Member

@regisd regisd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@regisd regisd assigned lsf37 and unassigned regisd May 16, 2020
@lsf37
Copy link
Member

lsf37 commented May 28, 2020

Sorry for the delay, I need to read up a bit on what exactly maven is doing there to understand what we're doing. Reproducible build as such is a good idea, I'm all for it.

@regisd regisd mentioned this pull request Dec 18, 2020
Closed
@hboutemy
Copy link
Contributor Author

hboutemy commented Dec 19, 2020

@lsf37 don't hesitate to ping me if you need any explanation

notice that Reproducible Central is now live and with many releases: https://github.com/jvm-repo-rebuild/reproducible-central
it would be nice to add next release of jflex to the list of independently verified reproducible builds

@regisd
Copy link
Member

regisd commented Dec 19, 2020

I think using a timestamp is a bad practice, but it seems Maven can't do better. LGTM.

@regisd regisd changed the title make build reproducible Make maven build reproducible Dec 19, 2020
@regisd regisd linked an issue Dec 19, 2020 that may be closed by this pull request
jflex-maven-plugin - Regeneration of previously generated classes changes modification date of the output file #720
Closed
@regisd
Copy link
Member

regisd commented Dec 19, 2020

As far as I understand, this will fix #720. I've updated the change description.

@hboutemy
Copy link
Contributor Author

hboutemy commented Dec 19, 2020

I think using a timestamp is a bad practice, but it seems Maven can't do better. LGTM.

you need something reproducible for files timestamp in zip archives: any better idea welcome :)

@hboutemy
Copy link
Contributor Author

hboutemy commented Dec 19, 2020

As far as I understand, this will fix #720. I've updated the change description.

no, i don't think so

this PR is about getting the same binary JFlex .jar output when rebuilding: it does not change anything to how JFlex works

@regisd regisd marked this pull request as draft December 25, 2020 18:08
@lsf37 lsf37 marked this pull request as ready for review January 7, 2023 05:45
@lsf37
Copy link
Member

lsf37 commented Jan 7, 2023

(rebased and resolved conflicts)

@lsf37 lsf37 removed a link to an issue Jan 7, 2023
jflex-maven-plugin - Regeneration of previously generated classes changes modification date of the output file #720
Closed
lsf37
lsf37 approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for pinging us to do that, and sorry that it took forever..

@lsf37 lsf37 merged commit d152ba1 into jflex-de:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@regisd regisd regisd left review comments

@lsf37 lsf37 lsf37 approved these changes

Assignees

@lsf37 lsf37

Labels

enhancement Feature requests

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hboutemy @lsf37 @regisd