Check %include files' modified times for rebuild too#693
Check %include files' modified times for rebuild too#693lsf37 merged 1 commit intojflex-de:masterfrom
Conversation
|
Thanks for your contribution! I’ll give @regisd some time to review, but this looks good from my side. We should probably add nested include files afterwards in a separate commit. |
Only checking files for %include statements in a JFlex file and not any nested %include files.
|
Thank you for the review, @lsf37. I'm going to push a tweak to more exactly align the plugin's "guessing" regex matching with the LexScan.flex syntax for and to fix a typo. (Would you like me to create an issue for considering nested includes for last-modifed checking?) |
8e4a033 to
e4dd356
Compare
|
Thanks for the tweak, you're right that's closer to the expression in JFlex.
Yes, please. I was going to do it right after the merge, but better to make sure I don't forget. Looking through the code again, one question: is there a deeper reason for ignoring the include files in |
Oh my thinking was that the existing |
Got it. The class is currently only used to determine the output file name, but it makes sense the store the include file data here as well. I might rename it to @regisd is probably enjoying the holidays, so I'll merge now and we can address any changes later when he returns. |
|
Thanks again for the contribution! |
|
My pleasure! Thank you for the collaboration |
Hello,
Please consider for integration this patch for the jflex-maven-plugin to check also last-modified times for
%includefiles in a JFlex file when possibly short-circuiting a rebuild. (It had been suggested in #217 that the jflex-maven-plugin supported this already, but I did not find that to be the case.)Only
%includefiles directly referenced by alexFilewould be checked by this patch and not any nested%includestatements.Thank you.