Conversation
Char classes still need to be mutable at this point. They can only be made immutable after the semantic analysis phase at the end of parsing.
By default JFlex emits @SuppressWarnings("fallthrough") at the class level. This directive removes that annotation and leaves it up to the user to define their own. Fixes #762
Looks like BUILD.bzl wasn't picked up; renamed to BUILD.bazel and fixed output drift.
- LexScan.java: uncaught-number-format-exception: Format is checked by the lexer spec. - LexScan.java: misleading-indentation: in comment only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The directive causes the
@SuppressWarnings("fallthrough")annotation to be omitted, enabling users to provide their own annotations.This should allow the scenario in #762 to work.