Issue #4598 - rework InetAccessHandler to use path mappings#4615
Merged
lachlan-roberts merged 5 commits intojetty-10.0.xfrom Mar 1, 2020
Merged
Issue #4598 - rework InetAccessHandler to use path mappings#4615lachlan-roberts merged 5 commits intojetty-10.0.xfrom
lachlan-roberts merged 5 commits intojetty-10.0.xfrom
Conversation
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…er' into jetty-10.0.x-4598-InetAccessHandler
gregw
approved these changes
Feb 28, 2020
Contributor
gregw
left a comment
There was a problem hiding this comment.
I think this is a much better approach. It is a pity about the changed API and I think we should deprecate those methods to help, but other than those niggles: LGTM
jetty-server/src/main/java/org/eclipse/jetty/server/handler/InetAccessHandler.java
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/handler/InetAccessSet.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #4598
InetAccessHandler now works on patterns with an optional connector name, address and URI mapping.
The connector name is separated from the InetAddress pattern with an '@' character, and the InetAddress pattern is separated from the URI pattern using the "|" (pipe) character.
Examples:
- "connector1@127.0.0.1|/foo"
- "127.0.0.1|/foo"
- "connector1@127.0.0.1"
- "127.0.0.1"
Note: this completely changes the previous behaviour where the set of connector names defined only which connectors you wanted the filter to apply to. Now the code:
will include any requests from the address
127.0.0.1OR requests onconnector1.