Issue #4572 - Introduce jetty-slf4j-impl (part 1 of 3)#4601
Merged
joakime merged 1 commit intojetty-10.0.xfrom Mar 16, 2020
Merged
Issue #4572 - Introduce jetty-slf4j-impl (part 1 of 3)#4601joakime merged 1 commit intojetty-10.0.xfrom
joakime merged 1 commit intojetty-10.0.xfrom
Conversation
Closed
sbordet
requested changes
Feb 25, 2020
Contributor
sbordet
left a comment
There was a problem hiding this comment.
I think we should care a little about the performance, since we do have features that can be enabled in production where we want to minimize the logging impact. Following this line, the design should not force inefficiencies - the initial implementation can but at least can be replaced.
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyAppender.java
Outdated
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyLogger.java
Outdated
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyLoggerFactory.java
Outdated
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyLoggerFactory.java
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyLoggerFactory.java
Outdated
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyLoggingServiceProvider.java
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyLoggingServiceProvider.java
Outdated
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/StacklessLogging.java
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/StdErrAppender.java
Outdated
Show resolved
Hide resolved
gregw
requested changes
Feb 25, 2020
olamy
reviewed
Feb 26, 2020
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/StdErrAppender.java
Outdated
Show resolved
Hide resolved
gregw
requested changes
Feb 26, 2020
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyLoggerFactory.java
Outdated
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/StdErrAppender.java
Outdated
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/StdErrAppender.java
Outdated
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/StdErrAppender.java
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/StdErrAppender.java
Outdated
Show resolved
Hide resolved
gregw
reviewed
Feb 26, 2020
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyLoggerFactory.java
Outdated
Show resolved
Hide resolved
gregw
reviewed
Feb 26, 2020
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyLoggerFactory.java
Outdated
Show resolved
Hide resolved
sbordet
reviewed
Feb 26, 2020
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyLoggerFactory.java
Outdated
Show resolved
Hide resolved
olamy
approved these changes
Feb 26, 2020
sbordet
approved these changes
Feb 26, 2020
* Introducing jetty-slf4j-impl
* Make Jetty use org.slf4j
* Removed most of org.eclipse.jetty.util.log classes
* Left org.eclipse.jetty.util.log.Log and
org.eclipse.jetty.util.log.Logger but as
simple bridge classes that are deprecated
* Migrated code using org.eclipse.jetty.util.log.StacklessLogging
to org.eclipse.jetty.logging.StacklessLogging found in
the jetty-slf4j-impl
* Moved logging start modules from jetty-util to jetty-home
* Simplified logging start modules
* Updated code that was using StdErrLog directly
* Updating module-info.java for org.slf4j
* removing org.eclipse.jetty.util.log.class references
* jetty-start supports manually declared default provider
+ and we use it to default "logging" to the "logging-jetty" provider
* Cleaning up jetty-maven-plugin and IT testing for Logging
* Using old slf4j for it testing
* Updating compiler config to show Xlint:exports warnings
* Updating console-capture and logging-noop
* Adding slf4j bridge (capture) jetty modules
* Updates to jetty logging module locations
* Changing reference to slf4j dependent mod
* Process requested enabled modules in topological order
* Limiting inclusions in shaded jetty-start
+ Also adding note to jetty-util classes that are used by
jetty-start
* Default logging level on baseline logging config is INFO (not DEBUG)
* Changing from system to server classes in logging
* Updating other modules to use new logging names
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
c39897c to
8b7e649
Compare
Contributor
Author
|
Merged (manually) into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 1 (of 3) for the Replace Jetty Logging with slf4j effort.
See PR #4643 for part 2.
Introduction of slf4j implementation that performs what StdErrLog does.
This is the initial PR to focus the new work on.
A followup PR will occur after this one has been accepted, and will represent the change over to slf4j-api (and using this new
jetty-slf4j-implmodule for use in testing andjetty-home)