Skip to content

Issue #4572 - Introduce jetty-slf4j-impl (part 1 of 3)#4601

Merged
joakime merged 1 commit intojetty-10.0.xfrom
jetty-10.0.x-4572-new-slf4j-logger-impl
Mar 16, 2020
Merged

Issue #4572 - Introduce jetty-slf4j-impl (part 1 of 3)#4601
joakime merged 1 commit intojetty-10.0.xfrom
jetty-10.0.x-4572-new-slf4j-logger-impl

Conversation

@joakime
Copy link
Copy Markdown
Contributor

@joakime joakime commented Feb 24, 2020

This is part 1 (of 3) for the Replace Jetty Logging with slf4j effort.

See PR #4643 for part 2.

Introduction of slf4j implementation that performs what StdErrLog does.

This is the initial PR to focus the new work on.

A followup PR will occur after this one has been accepted, and will represent the change over to slf4j-api (and using this new jetty-slf4j-impl module for use in testing and jetty-home)

@joakime joakime requested review from olamy and sbordet February 24, 2020 19:24
@joakime joakime added this to the 10.0.x milestone Feb 24, 2020
@joakime joakime linked an issue Feb 24, 2020 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should care a little about the performance, since we do have features that can be enabled in production where we want to minimize the logging impact. Following this line, the design should not force inefficiencies - the initial implementation can but at least can be replaced.

@joakime joakime requested review from gregw and sbordet February 25, 2020 22:12
@joakime joakime requested review from gregw and sbordet February 26, 2020 21:12
@joakime joakime changed the title Issue #4572 - Introduce jetty-slf4j-impl Issue #4572 - Introduce jetty-slf4j-impl (part 1 of 3) Mar 5, 2020
* Introducing jetty-slf4j-impl
* Make Jetty use org.slf4j
* Removed most of org.eclipse.jetty.util.log classes
* Left org.eclipse.jetty.util.log.Log and
       org.eclipse.jetty.util.log.Logger but as
  simple bridge classes that are deprecated
* Migrated code using org.eclipse.jetty.util.log.StacklessLogging
  to org.eclipse.jetty.logging.StacklessLogging found in
  the jetty-slf4j-impl
* Moved logging start modules from jetty-util to jetty-home
* Simplified logging start modules
* Updated code that was using StdErrLog directly
* Updating module-info.java for org.slf4j
* removing org.eclipse.jetty.util.log.class references
* jetty-start supports manually declared default provider
  + and we use it to default "logging" to the "logging-jetty" provider
* Cleaning up jetty-maven-plugin and IT testing for Logging
* Using old slf4j for it testing
* Updating compiler config to show Xlint:exports warnings
* Updating console-capture and logging-noop
* Adding slf4j bridge (capture) jetty modules
* Updates to jetty logging module locations
* Changing reference to slf4j dependent mod
* Process requested enabled modules in topological order
* Limiting inclusions in shaded jetty-start
  + Also adding note to jetty-util classes that are used by
    jetty-start
* Default logging level on baseline logging config is INFO (not DEBUG)
* Changing from system to server classes in logging
* Updating other modules to use new logging names

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime force-pushed the jetty-10.0.x-4572-new-slf4j-logger-impl branch from c39897c to 8b7e649 Compare March 16, 2020 16:22
@joakime joakime merged commit 8b7e649 into jetty-10.0.x Mar 16, 2020
@joakime
Copy link
Copy Markdown
Contributor Author

joakime commented Mar 16, 2020

Merged (manually) into jetty-10.0.x

@joakime joakime deleted the jetty-10.0.x-4572-new-slf4j-logger-impl branch March 17, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Jetty Logging

4 participants