Skip to content

Tests #4594 ContextListener removed#4595

Merged
gregw merged 1 commit intojetty-9.4.xfrom
jetty-9.4.x-4594-destroyServletContextListeners
Feb 22, 2020
Merged

Tests #4594 ContextListener removed#4595
gregw merged 1 commit intojetty-9.4.xfrom
jetty-9.4.x-4594-destroyServletContextListeners

Conversation

@gregw
Copy link
Copy Markdown
Contributor

@gregw gregw commented Feb 20, 2020

Remove ContextListeners from the destroy list when removed.

Signed-off-by: Greg Wilkins gregw@webtide.com

Remove ContextListeners from the destroy list when removed.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw requested a review from joakime February 20, 2020 17:23
Copy link
Copy Markdown
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me. (it's really just a 1 line change + a typo on a private field name fix)
But we really need unit tests for this to prevent a regression in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants