Skip to content

Issue #4571 - websocket aggregating text and binary MessageSinks#4593

Merged
lachlan-roberts merged 4 commits intojetty-10.0.xfrom
jetty-10.0.x-4571-MessageSink
Mar 11, 2020
Merged

Issue #4571 - websocket aggregating text and binary MessageSinks#4593
lachlan-roberts merged 4 commits intojetty-10.0.xfrom
jetty-10.0.x-4571-MessageSink

Conversation

@lachlan-roberts
Copy link
Copy Markdown
Contributor

Issue #4571

  • single frame BINARY messages do not need to be aggregated
  • simplify other MessageSinks
  • verify and test invalid UTF-8 behaviour on TEXT message sinks

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts requested review from gregw and joakime and removed request for gregw February 20, 2020 23:53
* UTF-8 and a non fin frame can contain partial UTF-8 characters.</p>
* @return the payload as a UTF-8 string.
*/
public String getPayloadAsUTF8()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps not public if it is just for testing?

Copy link
Copy Markdown
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lachlan-roberts lachlan-roberts merged commit b0ddba4 into jetty-10.0.x Mar 11, 2020
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-4571-MessageSink branch March 11, 2020 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

review performance of websocket MessageSink classes in jetty-10

2 participants