Skip to content

Issue #4538 - rework of websocket message reader and writers#4588

Merged
lachlan-roberts merged 9 commits intojetty-10.0.xfrom
jetty-10.0.x-4538-MessageReaderWriter
Mar 11, 2020
Merged

Issue #4538 - rework of websocket message reader and writers#4588
lachlan-roberts merged 9 commits intojetty-10.0.xfrom
jetty-10.0.x-4538-MessageReaderWriter

Conversation

@lachlan-roberts
Copy link
Copy Markdown
Contributor

Issue #4538

  • MessageReader and MessageWriter delegate to using MessageInputStream/MessageOutputStream to reduce the duplication of the code
  • MessageReader and MessageWriter now do UTF-8 validation
  • Rework of MessageInputStream

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Message reader now validates UTF8

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Copy link
Copy Markdown
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lachlan-roberts lachlan-roberts linked an issue Mar 11, 2020 that may be closed by this pull request
@lachlan-roberts lachlan-roberts merged commit b1d30fc into jetty-10.0.x Mar 11, 2020
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-4538-MessageReaderWriter branch March 11, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

review WebSocket MessageWriter and MessageReader

2 participants