Skip to content

Fix bad URL to URI conversion in ResourceFactory.newClassLoaderResource()#12921

Merged
lorban merged 2 commits into
jetty-12.0.xfrom
fix/jetty-12.0.x/12913-newClassLoaderResource-url-to-uri
Mar 19, 2025
Merged

Fix bad URL to URI conversion in ResourceFactory.newClassLoaderResource()#12921
lorban merged 2 commits into
jetty-12.0.xfrom
fix/jetty-12.0.x/12913-newClassLoaderResource-url-to-uri

Conversation

@lorban

@lorban lorban commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Fixes #12913

@lorban
#12913 fix bad URL to URI conversion in newClassLoaderResource()
45c9754 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban added the Bug For general bugs on Jetty side label Mar 19, 2025
@lorban lorban requested a review from joakime March 19, 2025 13:50
@lorban lorban self-assigned this Mar 19, 2025
@lorban

lorban commented Mar 19, 2025

Copy link
Copy Markdown
Contributor Author

Now I wonder if ResourceFactory.newResource(URL) is missing URIUtil.correctURI() calls too?

@lorban lorban moved this to 🏗 In progress in Jetty 12.0.19 - FROZEN Mar 19, 2025
joakime
joakime previously approved these changes Mar 19, 2025
View reviewed changes
@joakime

joakime commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Now I wonder if ResourceFactory.newResource(URL) is missing URIUtil.correctURI() calls too?

If we want to be consistent, esp for file: scheme, then we should do it there too.

@lorban
#12913 fix bad URL to URI conversion in newResource(URL)
b71fbfe 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban

lorban commented Mar 19, 2025

Copy link
Copy Markdown
Contributor Author

Now I wonder if ResourceFactory.newResource(URL) is missing URIUtil.correctURI() calls too?

If we want to be consistent, esp for file: scheme, then we should do it there too.

As I thought, so I've modified ResourceFactory.newResource(URL) similarly. Thanks!

@lorban lorban requested a review from joakime March 19, 2025 14:48
@lorban lorban merged commit 621c357 into jetty-12.0.x Mar 19, 2025
@lorban lorban deleted the fix/jetty-12.0.x/12913-newClassLoaderResource-url-to-uri branch March 19, 2025 16:38
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.19 - FROZEN Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joakime joakime joakime approved these changes

Assignees

@lorban lorban

Labels

Bug For general bugs on Jetty side

Projects

No open projects
Jetty 12.0.19 - FROZEN
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Resource located inside JAR file is wrongfully treated as an alias

2 participants

@lorban @joakime