Start of a testcases for ByteBufferPool contract#12432
Closed
joakime wants to merge 1 commit into
Closed
Conversation
lorban
requested changes
Oct 30, 2024
lorban
left a comment
Contributor
There was a problem hiding this comment.
Actually, I was wrong. ArrayByteBufferPoolTest.testEndiannessResetOnRelease() does test that the endianness gets reset upon release. And since 12.0 we figured that only ArrayByteBufferPool was worth keeping (Tracking being a subclass only useful for testing and troubleshooting) as other implementations like ByteBufferPool came with more problems than solutions.
So I think this PR isn't needed.
Contributor
Author
|
Closing as not-needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out at #12075 (comment) it seems we lack tests for the ByteBuffer.order() reset of the ByteBufferPool implementations.
This is just a simple testcase that tests that, but it likely needs more implementations to test.