Skip to content

do not add duplicate jars to MetaData containerResources#10902

Merged
lachlan-roberts merged 4 commits intojetty-12.0.xfrom
jetty-12.0.x-addContainerResource
Nov 22, 2023
Merged

do not add duplicate jars to MetaData containerResources#10902
lachlan-roberts merged 4 commits intojetty-12.0.xfrom
jetty-12.0.x-addContainerResource

Conversation

@lachlan-roberts
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
janbartel
janbartel previously approved these changes Nov 17, 2023
Copy link
Copy Markdown
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this change, however probably should output a WARN that there is a duplicate jar on the container path. Also do same for ee9.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@janbartel
Copy link
Copy Markdown
Contributor

+1

janbartel
janbartel previously approved these changes Nov 17, 2023
olamy
olamy previously approved these changes Nov 17, 2023
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts dismissed stale reviews from olamy and janbartel via 9a9d8fb November 19, 2023 23:09
@joakime
Copy link
Copy Markdown
Contributor

joakime commented Nov 22, 2023

@lachlan-roberts what project is this PR for?

@lachlan-roberts lachlan-roberts merged commit 4a91cb7 into jetty-12.0.x Nov 22, 2023
@lachlan-roberts lachlan-roberts deleted the jetty-12.0.x-addContainerResource branch November 22, 2023 21:36
@lachlan-roberts lachlan-roberts added the Sponsored This issue affects a user with a commercial support agreement label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sponsored This issue affects a user with a commercial support agreement

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants