Remove the extra whitespace around the supplied (or ommitted) exclude regexes#622
Merged
Remove the extra whitespace around the supplied (or ommitted) exclude regexes#622
Conversation
68bf5c1 to
98f319f
Compare
… regexes Signed-off-by: Richard Wall <richard.wall@venafi.com>
98f319f to
f0c0643
Compare
maelvls
approved these changes
Nov 18, 2024
Member
maelvls
left a comment
There was a problem hiding this comment.
Thanks for the thorough testing, as well as the well-written description! I haven't tested the changes myself. I am confident that nothing will break, though, thanks to your extensive testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Testing
I ran the e2e test and it succeeded:
Then I got the resulting configmap and saw that it contained the new supplied annotation exclusion, but that the excludeLabel field was omitted, as expected, which did not cause any problems: