Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jetstack/jetstack-secure
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.7.0-alpha.2
Choose a base ref
...
head repository: jetstack/jetstack-secure
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.7.0-alpha.3
Choose a head ref
  • 2 commits
  • 19 files changed
  • 1 contributor

Commits on Sep 25, 2025

  1. Merge pull request #727 from jetstack/disco-agent-rename

    [VC-45349] Rename cyberark-disco-agent to disco-agent across repo
    wallrj-cyberark authored Sep 25, 2025
    Configuration menu
    Copy the full SHA
    0ae6dbd View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2025

  1. Add cluster name and description to CyberArk Discovery and Context sn…

    …apshot
    
    The purpose of the change is to give Discovery and Context service operators a
    clear way to communicate uploaded secret findings and remediations with a team
    or contact for the origin cluster, by allowing the platform-team to supply these
    new configuration values when they deploy the agent:
    
    -   `config.clusterName` — a human‑readable cluster name, and
    -   `config.clusterDescription` — a short description (contact info, purpose).
    
    These new fields are optional. If the clusterName is empty, the `ARK_USERNAME`
    is used as the cluster-name. The rationale is that each agent deployment will be
    assigned a unique "service account" which should be given a username derived
    from the name of the target cluster. Therefore the service account username will
    be sufficient information for the security team to communicate risks and
    remediations to the platform team responsible for the cluster.
    
    This provides an imperfect, but expedient improvement for Web UI users and
    support for on‑prem / non‑cloud deployments which can be improved in future if
    with more backend/ cloud discovery work.
    
    It wasn't strictly necessary, but I also tried to sort out the confusion around
    the `cluster_id` and the `cluster_name`. I've added a new `cluster_name` field
    to the config file and updated the `venafi-kubernetes-agent` chart to set that
    config field instead of the overloading the `cluster_id` field which is used for
    other purposes by the much older Jetstack Secure agent.
    
    Summary of changes:
    - Add ClusterName and ClusterDescription fields to Snapshot struct
    - Populate these fields from Options in PostDataReadingsWithOptions
    - Add clusterName and clusterDescription Helm values and docs
    - Populate cluster_id and cluster_description in the rendered configmap
    - Update values.schema.json to include descriptions for the new values
    - Add ClusterDescription field to pkg/agent Config and CombinedConfig
    - Default MachineHub cluster name from ARK_USERNAME env when not set
    
    Signed-off-by: Richard Wall <richard.wall@cyberark.com>
    wallrj-cyberark committed Oct 9, 2025
    Configuration menu
    Copy the full SHA
    a8f7fe8 View commit details
    Browse the repository at this point in the history
Loading