This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Expose registry host to helm hooks DEV-1249#17
Merged
Conversation
683ed2f to
2bb3429
Compare
2bb3429 to
005935d
Compare
mikeland73
approved these changes
Nov 11, 2022
Contributor
mikeland73
left a comment
There was a problem hiding this comment.
Approving to unblock, but you can use published images to determine the host, no need to export a separate host.
| helm.NewImageProvider( | ||
| buildOutput.Image.String(), | ||
| publishOutput.PublishedImages(), | ||
| string(publishOutput.RegistryHost), |
Contributor
There was a problem hiding this comment.
This should not be needed. The published images have enough information to determine the host. (they are the hostname on the published image URL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose registry host information for helm hooks to access.
How was it tested?
launchpad up on BYOC + custom ECR
Is this change backwards-compatible?
Yes