This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Capture public aws ecr image repository uri DEV-1247#16
Merged
Conversation
mikeland73
approved these changes
Nov 11, 2022
Contributor
mikeland73
left a comment
There was a problem hiding this comment.
OMG, I don't like this regex at all but not your fault.
I wonder if doing just a few string contains checks might be easier to read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aws ECR regex should match private and public repository uri. Public ECR URI prefixes with
public.ecr.aws/How was it tested?
launchpad up
Is this change backwards-compatible?
yes