This repository was archived by the owner on Jun 13, 2025. It is now read-only.
[cluster] Add selected cluster to cluster provider interface#13
Merged
mikeland73 merged 1 commit intomainfrom Nov 8, 2022
Merged
Conversation
LucilleH
approved these changes
Nov 8, 2022
| } | ||
|
|
||
| if *providers.ClusterProvider().GetSelectedClusterName() == "" { | ||
| providers.ClusterProvider().SetSelectedClusterName(c.Cluster) |
There was a problem hiding this comment.
Do we still care about the --cluster flag?
Contributor
Author
There was a problem hiding this comment.
If we want we can remove, but I didn't want to make that call in this PR. FWIW, I find it useful for testing (e.g. -c docker-desktop)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This simplifies the cluster provider interface by removing the need to pass a cluster name every time we call
Get(). This uses state in the provider which is associated to the cluster flag and also set when the jetconfig is read.How was it tested?
--clusterflag)Is this change backwards-compatible?
yes