Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Do not deploy runtime chart if runtime is not needed DEV-1225#12

Merged
LucilleH merged 3 commits intomainfrom
lucille--auth-helm
Nov 9, 2022
Merged

Do not deploy runtime chart if runtime is not needed DEV-1225#12
LucilleH merged 3 commits intomainfrom
lucille--auth-helm

Conversation

@LucilleH
Copy link
Copy Markdown

@LucilleH LucilleH commented Nov 8, 2022

Summary

If runtime is not needed, do not deploy runtime helm chart

How was it tested?

launchpad up

Is this change backwards-compatible?

Yes

@LucilleH LucilleH requested a review from mikeland73 November 8, 2022 04:15
@mikeland73
Copy link
Copy Markdown
Contributor

Take a look at https://github.com/jetpack-io/launchpad/blob/main/launchpad/deploy.go#L312 which is already skipping the runtime. It looks like we're taking to slightly different approaches, maybe there's a way to unify?

@LucilleH
Copy link
Copy Markdown
Author

LucilleH commented Nov 8, 2022

Take a look at https://github.com/jetpack-io/launchpad/blob/main/launchpad/deploy.go#L312 which is already skipping the runtime. It looks like we're taking to slightly different approaches, maybe there's a way to unify?

Oh good point. Updated.

The previous way have a downside of downloading and generating the information needed for the runtime chart which requires user information, even when runtime is not needed. The current way avoids this step if runtime is not needed.

I think we still need the runSDKRegistration bool for the helm chart values so I'll keep that, and that is also derived from the same detect.Sdk function. So I think now it is unified. Thoughts? @mikeland86

@LucilleH LucilleH requested a review from ipince November 9, 2022 17:27
Comment thread padcli/command/deploy.go Outdated
return nil, err
}

var runtimeHelm *launchpad.HelmOptions
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to line 112 (closer to its assignment)?

@LucilleH LucilleH merged commit 487cb84 into main Nov 9, 2022
@LucilleH LucilleH deleted the lucille--auth-helm branch November 9, 2022 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants