Do not deploy runtime chart if runtime is not needed DEV-1225#12
Do not deploy runtime chart if runtime is not needed DEV-1225#12
Conversation
|
Take a look at https://github.com/jetpack-io/launchpad/blob/main/launchpad/deploy.go#L312 which is already skipping the runtime. It looks like we're taking to slightly different approaches, maybe there's a way to unify? |
87c85a7 to
1315872
Compare
Oh good point. Updated. The previous way have a downside of downloading and generating the information needed for the runtime chart which requires user information, even when runtime is not needed. The current way avoids this step if runtime is not needed. I think we still need the |
| return nil, err | ||
| } | ||
|
|
||
| var runtimeHelm *launchpad.HelmOptions |
There was a problem hiding this comment.
move to line 112 (closer to its assignment)?
Summary
If runtime is not needed, do not deploy runtime helm chart
How was it tested?
launchpad up
Is this change backwards-compatible?
Yes