This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Read whether a cluster is Jetpack-managed or not from the kubeconfig#10
Merged
Read whether a cluster is Jetpack-managed or not from the kubeconfig#10
Conversation
LucilleH
reviewed
Nov 7, 2022
| return &kubeConfigCluster{ | ||
| kubeContextName: kubeContextName, | ||
| local: isLocal, | ||
| jetpackManaged: isJetpackManaged, |
There was a problem hiding this comment.
Do we need to update the IsJetpackManaged()? It looks at c.managed field instead
Contributor
Author
There was a problem hiding this comment.
hm?
It looks at:
func (c *kubeConfigCluster) IsJetpackManaged() bool {
return c.jetpackManaged
}
But relatedly, IsRemoteUnmanaged() should change
LucilleH
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Determine whether a cluster in a kubeconfig is Jetpack-managed or not by reading its
execcommand in the kubeconfig. This is just a good enough/temporary solution. In the future, we should be writing this information somewhere or exposing some API that can provide this information.How was it tested?
Tested by printing out some extra information in
launchpad initand ran it against my existing kubeconfigIs this change backwards-compatible?
Yes