Replace github cache action with restore and save#24
Merged
Conversation
5c711d4 to
35fb858
Compare
35fb858 to
7dd68e9
Compare
mikeland73
approved these changes
Oct 4, 2023
Contributor
mikeland73
left a comment
There was a problem hiding this comment.
Is there no way around this? Two downsides:
- More complexity from handling restore/save ourselves
- We save the cache even if the test fails which could potentially leave the cache in a bad state.
| with: | ||
| path: /usr/local/bin/devbox | ||
| key: ${{ runner.os }}-devbox-${{ env.latest_version }} | ||
| key: ${{ runner.os }}-devbox-cli-${{ env.latest_version }} |
Contributor
There was a problem hiding this comment.
I vote for not caching the cli. Do we really save anything? Downloading from s3 is basically a cache already.
Removing it makes the action simpler.
Contributor
Author
There was a problem hiding this comment.
I think the devbox launcher is fetching the actual binary from Github. When actions are running in parallel, we would hit the github rate limit.
Contributor
Author
Do you mean |
gcurtis
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Instead of letting
action/cachedo the restoring and saving cache for us, we choose when to restore and when to save cache.In this case, we will be saving cache immediately after the devbox package installation, instead of waiting for the action post run. This way, the
tarsudo permission stays intact until the cache is saved.More specifically,
action/cache/saveruns before the last step of restoringtarto its original permission (as oppose to after)