Merged
Conversation
4758f98 to
068937a
Compare
savil
reviewed
Sep 27, 2023
savil
left a comment
There was a problem hiding this comment.
lgtm, thanks! Why drop the step below?
| path: /usr/local/bin/devbox | ||
| key: ${{ runner.os }}-devbox-${{ env.latest_version }} | ||
|
|
||
| - name: Install devbox cli |
Contributor
Author
There was a problem hiding this comment.
Sorry good catch, that was a mistake. I readded it.
We have some problems in our custom runner with this action so I've tried it with skipping the installation via the included action and it works in our runners (we do not use the GitHub provided ones, we are using custom runners). In case you are wondering which action we are using, we use: `cachix/install-nix-action@v23` - I guess it has something to do with the usage of `sudo` in the other action but I'm not 100% sure on that.
068937a to
5f7448c
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some problems in our custom runner with this action so I've tried it with skipping the installation via the included action and it works in our runners (we do not use the GitHub provided ones, we are using custom runners).
In case you are wondering which action we are using, we use:
cachix/install-nix-action@v23- I guess it has something to do with the usage ofsudoin the other action but I'm not 100% sure on that.I'm also not sure about the differences between these two actions so I've opted for the possibility to skip the installation rather than changing the action as I guess you've put a lot of thought into which action to use.
Edit: I need to correct myself, it's not because of
sudobut because ofsystemd. I tried to run the action withoutsystemdby passing ininit: noneandplanner: linux-multibut I got other errors. So I would prefer to be able to just skip the installation and use my own / a different action to installnix.