fix(media): preserve outbound attachment filenames

obviyus · obviyus · commit fcc86f043b51 · 2026-04-21T14:19:27.000+05:30
diff --git a/src/media/outbound-attachment.test.ts b/src/media/outbound-attachment.test.ts
@@ -0,0 +1,39 @@
+import { describe, expect, it, vi } from "vitest";
+
+const loadWebMedia = vi.hoisted(() => vi.fn());
+const saveMediaBuffer = vi.hoisted(() => vi.fn());
+
+vi.mock("./web-media.js", () => ({
+  loadWebMedia,
+}));
+
+vi.mock("./store.js", () => ({
+  saveMediaBuffer,
+}));
+
+const { resolveOutboundAttachmentFromUrl } = await import("./outbound-attachment.js");
+
+describe("resolveOutboundAttachmentFromUrl", () => {
+  it("preserves the loaded file name when staging outbound media", async () => {
+    const buffer = Buffer.from("pdf");
+    loadWebMedia.mockResolvedValueOnce({
+      buffer,
+      contentType: "application/pdf",
+      fileName: "report.pdf",
+    });
+    saveMediaBuffer.mockResolvedValueOnce({
+      path: "/tmp/media/outbound/report---uuid.pdf",
+      contentType: "application/pdf",
+    });
+
+    await resolveOutboundAttachmentFromUrl("./report.pdf", 1024);
+
+    expect(saveMediaBuffer).toHaveBeenCalledWith(
+      buffer,
+      "application/pdf",
+      "outbound",
+      1024,
+      "report.pdf",
+    );
+  });
+});
diff --git a/src/media/outbound-attachment.ts b/src/media/outbound-attachment.ts
@@ -25,6 +25,7 @@ export async function resolveOutboundAttachmentFromUrl(
     media.contentType ?? undefined,
     "outbound",
     maxBytes,
+    media.fileName,
   );
   return { path: saved.path, contentType: saved.contentType };
 }

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ export async function resolveOutboundAttachmentFromUrl(`
`25`	`25`	`media.contentType ?? undefined,`
`26`	`26`	`"outbound",`
`27`	`27`	`maxBytes,`
	`28`	`+ media.fileName,`
`28`	`29`	`);`
`29`	`30`	`return { path: saved.path, contentType: saved.contentType };`
`30`	`31`	`}`