CosmosStoreSource: Simplify lifetime management #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6fbcc31 to
b066fd6
Compare
b066fd6 to
32b4d98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
CosmosStoreSource.Run, which inherited semantics fromCosmosSource.RunwithCosmosStoreSource.Start, which offers a clear and more composable contract.This allows one to compose a set of sources and sinks just as one can do with
FsKafka.Note that implementation of semantics regarding clean shutdown via Ctrl-C/Break will now involve explicit use of helpers such as
Async.AwaitKeyboardInterruptAsTaskCancelledException(currently public inPropulsion.CosmosStore.Infrastructure; that does not make sense as a long term home for it)