fix(babel): Handle ignored files in babel v7#4393
Merged
cpojer merged 3 commits intojestjs:masterfrom Aug 31, 2017
danez:patch-1
Merged
fix(babel): Handle ignored files in babel v7#4393cpojer merged 3 commits intojestjs:masterfrom danez:patch-1
cpojer merged 3 commits intojestjs:masterfrom
danez:patch-1
Conversation
In babel v7 `babel-core.transform()` might return null if a file is ignored. This makes babel-jest not throw a TypeError in this case.
Codecov Report
@@ Coverage Diff @@
## master #4393 +/- ##
=======================================
Coverage 56.17% 56.17%
=======================================
Files 191 191
Lines 6424 6424
Branches 6 6
=======================================
Hits 3609 3609
Misses 2812 2812
Partials 3 3Continue to review full report at Codecov.
|
Member
|
Thanks for submitting a fix :) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In babel v7
babel-core.transform()returns null if a file is ignored.This change makes babel-jest not throw a TypeError in this case.
Test plan
Tested by modifying local installed babel-jest in babel, while trying to get jest running in babel itself.