Integrated with Yarn workspaces#3906
Merged
bestander merged 6 commits intojestjs:masterfrom Jul 7, 2017
bestander:workspaces
Merged
Integrated with Yarn workspaces#3906bestander merged 6 commits intojestjs:masterfrom bestander:workspaces
bestander merged 6 commits intojestjs:masterfrom
bestander:workspaces
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Yarn 0.27 has workspaces feature that should be a better alternative to Lerna boostrapping.
Yarn workspaces still don't replace Lerna (and probably won't do it completely for a long time), so Lerna publishing is still used for Jest.
This PR replaces Lerna bootstrap phase with Yarn workspaces.
Things to discuss:
It means that integration/examples test don't run in isolation from the workspace root so I removed symlinking to babel-jest et al. at the tests boostrapping.
One test
integration_tests/__tests__/transform.test.jsrequired to be running in isolation, so I changed the test bootstrap to execute on a copy on a temp folder.Known issues:
Test plan
yarn run publishand lerna seems to handle version bumping and npm publishing correctly