Update jsdom to a modern version#221
Conversation
Ideally we shouldn't need it. That's not completely true at this point but we should get any of these into jsdom proper.
|
\o/ We'll need PRs for I don't know what |
|
I was hoping I could get jest in a good enough state that it would pass its own tests on io.js, and then the team at FB could chip away at the compatibility layer since the suite of jest tests at FB is way bigger than anyone else's. I have no way of testing the CSS/HTML element shims myself. My motivation for io.js support was to get react-native and other OSS projects fully installing on io.js (react-native mostly does aside from the old version of jsdom), just to communicate where I'm coming from =) |
|
0.5 uses iojs and jsdom 5.x so closing out |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This isn't ready BUT I wanted to get this started. I think we should go all the way to current jsdom and skip any intermediate versions. We're just going to get stuck again unless we fix the underlying dependency issues.
CSSPropertyParsers?HTMLMediaElementis supported upstreamHTMLVideoElementis supported upstreamHTMLInputElement.checkedis supported upstream (Only uncheck radios in same form jsdom/jsdom#1007)HTMLSelectElementandmultipleselection is supported upstreamcc @domenic who may be able to answer some of the above about support (I bet I could look at changelogs/code, but I know you're interested anyway 😄). And @nhunzaker who was working on getting us to jsdom@1.5
If anybody wants to help out, let's do PRs against this branch.