Issue #15865 : Fixed the change to switch to the fallback#15867
Merged
SimenB merged 3 commits intojestjs:mainfrom Nov 19, 2025
Merged
Issue #15865 : Fixed the change to switch to the fallback#15867SimenB merged 3 commits intojestjs:mainfrom
SimenB merged 3 commits intojestjs:mainfrom
Conversation
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
ahnpnl
reviewed
Nov 4, 2025
Contributor
ahnpnl
left a comment
There was a problem hiding this comment.
would it be better if we add support for require ESM for Jest instead of always disabling that feature? Given that Jest already partially supports ESM, we should not move away from that.
SimenB
approved these changes
Nov 19, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15865
##Summary
Problem: In Jest’s VM, process.features.require_module can be true (inherited from Node), causing defensive code to attempt require('./some-esm.js') and throw “Must use import to load ES Module”.
Fix: In packages/jest-util/src/createProcessObject.ts, when creating Jest’s VM process, override process.features.require_module to always return false (if the flag exists). This aligns the flag with Jest’s capabilities so defensive code takes the fallback path.
Scope: Only the VM’s process.features.require_module getter is affected, guarded behind presence checks. No other global behaviors are changed.
Changed files:
packages/jest-util/src/createProcessObject.ts
packages/jest-util/src/tests/installCommonGlobals.test.ts (new assertion added)
##Test plan
Added a test verifying the override:
packages/jest-util/src/tests/installCommonGlobals.test.ts
it('overrides process.features.require_module to false when present', ...)
Commands run and output:
yarn install --immutable
yarn build:ts
yarn build:js
yarn jest packages/jest-util/src/tests/installCommonGlobals.test.ts --color
Output:
PASS packages/jest-util/src/tests/installCommonGlobals.test.ts
✓ returns the passed object (63 ms)
✓ turns a V8 global object into a Node global object (3 ms)
✓ overrides process.features.require_module to false when present (2 ms)
Test Suites: 1 passed, 1 total
Tests: 3 passed, 3 total
Snapshots: 0 total
Time: 0.422 s