Deploy preview for jestjs ready!

Built without sensitive environment variables with commit 1495e07

https://deploy-preview-11191--jestjs.netlify.app

Deploy preview for jestjs ready!

Built without sensitive environment variables with commit 23e5f42

https://deploy-preview-11191--jestjs.netlify.app

Deploy preview for jestjs ready!

Built without sensitive environment variables with commit 507c635

https://deploy-preview-11191--jestjs.netlify.app

Codecov Report

Merging #11191 (507c635) into master (858c50b) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #11191      +/-   ##
==========================================
- Coverage   64.31%   64.27%   -0.05%     
==========================================
  Files         307      307              
  Lines       13444    13458      +14     
  Branches     3281     3285       +4     
==========================================
+ Hits         8647     8650       +3     
- Misses       4090     4101      +11     
  Partials      707      707              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 858c50b...507c635. Read the comment docs.

@thymikee this is ESM already as we cannot support async transformation for CJS, although via type: 'module' in package.json rather than mjs extension.

Or am I misunderstanding your question? 😅 Did you mean the transformer should be ESM?

I meant the file to be my-transform.mjs and checking if a transform can be written in ESM instead of CJS. But I'm not really up to the speed with all the ESM changes, so pardon if I ask some dummy questions 🙈

Ah! I added a test for that together with the feature in #11163.

This PR is that the transformation can be async, not transformers. Should rename something...

Perfect, thanks! I see these are separate responsibilities, could have checked it before asking :)

No problem 👍

Hmm, I observed something odd. After adopting next-5, transformer lost this value in getCacheKey and process when running with Node ESM. That doesn't occur with Node CommonJS. Is this behavior expected or is it a bug?

An example is

const path = require('path');

class MyTransformer {
    process(src, filename, config, options) {
         console.log('this value', this); // this is undefined when running Jest in ESM mode

         return 'module.exports = ' + JSON.stringify(path.basename(filename)) + ';';
    },
}

module.exports = {
  createTransformer: () => new MyTransformer(),
};

Please open up a separate issue.

Note that we've never really supported using classes, so I don't think we've ever officially supported any form of this. However, I'm surprised this changed between next.4 and next.5

oh nvm, i think something funky with my node_modules :)

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.