Add support for recursiveDenylist option as an alternative to recursiveBlacklist#10649
Merged
SimenB merged 1 commit intojestjs:masterfrom Oct 19, 2020
wojtekmaj:no-non-inclusive-5-revived
Merged
Add support for recursiveDenylist option as an alternative to recursiveBlacklist#10649SimenB merged 1 commit intojestjs:masterfrom wojtekmaj:no-non-inclusive-5-revived
recursiveDenylist option as an alternative to recursiveBlacklist#10649SimenB merged 1 commit intojestjs:masterfrom
wojtekmaj:no-non-inclusive-5-revived
Conversation
SimenB
approved these changes
Oct 19, 2020
Member
SimenB
left a comment
There was a problem hiding this comment.
Thanks! Could you fix the linting errors in jest-validate/src/validate.ts?
Contributor
Author
|
I'm a complete idiot, I was so happy there are no errors, and turns out there were none because I forgot to install it 🙄 |
Member
|
Thanks @wojtekmaj! A PR which removes the old alias would be very much welcome, and I can land that when we start landing breaking changes 🙂 Just don't delete your fork so I can merge in master once I start landing 😀 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clone of #10236 which has to be closed because the original repo was deleted by me.
Part of #10235.
recursiveDenylistoption as an alternative torecursiveBlacklistinjest-validate. Does NOT removerecursiveBlacklistoption. It will continue to work, unless overwritten withrecursiveDenylist, to which I've given the priority.recursiveBlacklist(in favor of the newly added option).Changes internal calls tovalidate()to use new config (Maintainers: I'm not sure if that's a good idea - can you please advise? Should we expectjest-config, say, v26.2 work with other dependencies @ v26.1 at all times? Shall I roll that back and add it as a TODO to Replace non-inclusive terms used in configuration of jest-validate #10235 instead? TIA)Motivation
Part of continuous effort to get rid of non-inclusive terms like "whitelist" and "blacklist" implying that white = good and black = bad.
Test plan
jest-validatehad one suite whererecursiveBlacklistoption was used, in two cases:recursiveBlacklistoptionThe former was left intact, and copied 1:1 over to create a new test, testing whether
recursiveDenylistbeaves exactly the same asrecursiveBlacklist.The latter was updated to use
recursiveDenylist.Tests were ran successfully.